Draft
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Member
|
Is this related to #61641 ? |
Member
Author
Yeah, I decided to pivot. Since full JSON materialization is likely a performance bottleneck, I’m implementing a lazy JSON parser instead. |
anonrig
reviewed
Feb 17, 2026
| test('compound root array returns document with type "array"', (t) => { | ||
| const parser = new Parser(); | ||
| const doc = parser.parse('[1, 2, 3]'); | ||
| t.assert.strictEqual(doc.root().type(), 'array'); |
Member
There was a problem hiding this comment.
We shouldn't return string from this. This would be extremely slow. We can use an enum of numeric values called JSONType, and to .type() == JSONType.Array
anonrig
reviewed
Feb 17, 2026
| require('../common'); | ||
|
|
||
| const { test, describe } = require('node:test'); | ||
| const { Parser } = require('node:json_parser'); |
Member
There was a problem hiding this comment.
Why limit the module name to only parser?
Suggested change
| const { Parser } = require('node:json_parser'); | |
| const { JSONParser } = require('node:json'); |
anonrig
reviewed
Feb 17, 2026
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
- Docs are missing.
- Tests handling each edge case (errors) are missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.